Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mistake about show is_delete record #48

Open
qiyueliuhuo23 opened this issue Dec 16, 2024 · 2 comments
Open

Mistake about show is_delete record #48

qiyueliuhuo23 opened this issue Dec 16, 2024 · 2 comments

Comments

@qiyueliuhuo23
Copy link

In Innodb_page_index.py:412, it was:
image
I think its supposed to be:

if self.DELETED != rheader.deleted:
	continue

When self.DELETED == True, we want to print is_deleted == True records.

@ddcw
Copy link
Owner

ddcw commented Dec 17, 2024

The current implemented feature is that when using --delete (self. SELETED=True), only the rows marked as deleted are printed.

your mean is print both normal lines and deleted lines ?

its good, next major version will use MASK to represent the output content.

4: DDL mask
2: SQL mask
1: DELETE mask

@qiyueliuhuo23
Copy link
Author

In this version, when --delete=False, both deleted and normal records are printed; when --delete=True, only deleted records are printed.
In my version, when --delete=False, only normal records are printed; when --delete=True, only deleted records are printed.
But, I think its better to use mask to control whether what kinds of records to print(deleted, normal or both)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants