Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allowing multiple spanning headers with modify_spanning_header(level) #2105

Open
wants to merge 15 commits into
base: main
Choose a base branch
from

Conversation

ddsjoberg
Copy link
Owner

@ddsjoberg ddsjoberg commented Dec 19, 2024

What changes are proposed in this pull request?

  • The modify_spanning_header(level) argument has been added to allow for multiple levels of spanning headers in the resulting tables. The remove_spanning_header() function has also been added to ease the removal of spanning headers. (Spanning header updates #2099)
  • The modify_footnote_spanning_header() function has been added to ease adding footnotes to spanning headers. A companion function, remove_footnote_spanning_header(), has been added to remove spanning headers.

If there is an GitHub issue associated with this pull request, please provide link.
closes #2099
closes #2108


Reviewer Checklist (if item does not apply, mark is as complete)

  • PR branch has pulled the most recent updates from main branch.
  • If a bug was fixed, a unit test was added.
  • Run pkgdown::build_site(). Check the R console for errors, and review the rendered website.
  • Code coverage is suitable for any new functions/features: devtools::test_coverage()
  • usethis::use_spell_check() runs with no spelling errors in documentation
  • All GitHub Action workflows pass with a ✅

When the branch is ready to be merged into master:

  • Update NEWS.md with the changes from this pull request under the heading "# gtsummary (development version)". If there is an issue associated with the pull request, reference it in parentheses at the end update (see NEWS.md for examples).
  • Increment the version number using usethis::use_version(which = "dev")
  • Run usethis::use_spell_check() again
  • Approve Pull Request
  • Merge the PR. Please use "Squash and merge".

@ddsjoberg ddsjoberg marked this pull request as ready for review December 20, 2024 00:12
@ddsjoberg ddsjoberg requested a review from edelarua December 20, 2024 00:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add modify_footnote_spanning_header() function Spanning header updates
1 participant