Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Preserve comments in files #10

Open
4 tasks
gassmoeller opened this issue Apr 6, 2017 · 4 comments
Open
4 tasks

Preserve comments in files #10

gassmoeller opened this issue Apr 6, 2017 · 4 comments

Comments

@gassmoeller
Copy link
Member

Ideally we would like to preserve user comments in parameter files, but this needs a number of changes in different projects:

  • dealii::ParameterHandler needs to get a new field for each parameter, that is read and written
  • parameter_gui::XMLReader needs to read this field, and put it in a comment panel upon loading a file
  • parameter_gui::MainWindow needs to allow modifying these comments
  • parameter_gui::XMLWriter and PRMWriter need to write this field upon writing a file
@tjhei
Copy link
Member

tjhei commented Apr 6, 2017

For your workflow dealii::ParameterHandler only needs to write this into the .xml format, right? This would avoid the problem of comments and the descriptions (that are currently printed) collide.

@gassmoeller
Copy link
Member Author

Yes, this should only be written when writing xml files.

@bangerth
Copy link
Member

bangerth commented Apr 6, 2017

Can you open corresponding issues for deal.II for the things that need to be implemented in the ParameterHandler class?

@gassmoeller
Copy link
Member Author

I opened dealii/dealii#4211 to track the deal.II part.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants