Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: upgrade to mui5 #133

Open
davidlag0 opened this issue Jan 3, 2023 · 2 comments
Open

chore: upgrade to mui5 #133

davidlag0 opened this issue Jan 3, 2023 · 2 comments
Labels
enhancement Enhancement of the code, not introducing new features. priority-medium This issue may be useful, and needs some attention.

Comments

@davidlag0
Copy link

@dec0dOS
This is to help track the changes to update the codebase to mui5. I have replicated the same changes you did on your commit on the dev branch and didn't come across any issues! It looks good but if you recall specific issues you faced, I can spend some time investigating and figuring out fixes.

@davidlag0 davidlag0 added the enhancement Enhancement of the code, not introducing new features. label Jan 3, 2023
@dec0dOS
Copy link
Owner

dec0dOS commented Jan 3, 2023

Some UI elements have been incorrectly aligned as I remember correctly.
Screenshot 2023-01-03 at 14 11 50
Screenshot 2023-01-03 at 14 11 57
Screenshot 2023-01-03 at 14 12 06

@davidlag0
Copy link
Author

Thank you, that helps! We should be able to see this in the code with automated snapshots. It will make it easier to make the necessary changes to keep the look exactly the same or very similar. I'll create a pull request for snapshots once I get them working with Jest!

@dec0dOS dec0dOS added the priority-medium This issue may be useful, and needs some attention. label Feb 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Enhancement of the code, not introducing new features. priority-medium This issue may be useful, and needs some attention.
Projects
None yet
Development

No branches or pull requests

2 participants