Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: implement rate-limiting for authorization #175

Closed
dec0dOS opened this issue Oct 9, 2023 · 6 comments
Closed

feat: implement rate-limiting for authorization #175

dec0dOS opened this issue Oct 9, 2023 · 6 comments
Labels
new-feature New features or options.

Comments

@dec0dOS
Copy link
Owner

dec0dOS commented Oct 9, 2023

Feature Request

Additional Context

More info here:
https://github.com/dec0dOS/zero-ui/security/code-scanning/5
@dec0dOS dec0dOS added the new-feature New features or options. label Oct 9, 2023
@aruznieto
Copy link
Contributor

Link doesnt work

@dec0dOS
Copy link
Owner Author

dec0dOS commented Oct 13, 2023

Seems like code scanning alerts are available only for maintainers. Here's the extracted data from the link:
Missing rate limiting · Code scanning alert #5 · dec0dOS:zero-ui.pdf

@aruznieto
Copy link
Contributor

WIP

@aruznieto aruznieto mentioned this issue Oct 15, 2023
Merged
9 tasks
@dec0dOS
Copy link
Owner Author

dec0dOS commented Oct 15, 2023

Closed with #179. Thanks, @aruznieto!

@dec0dOS dec0dOS closed this as completed Oct 15, 2023
@dec0dOS dec0dOS reopened this Oct 16, 2023
@dec0dOS
Copy link
Owner Author

dec0dOS commented Oct 16, 2023

Some issues with the rate limiter:
#181 (comment)

@dec0dOS
Copy link
Owner Author

dec0dOS commented Oct 16, 2023

Fixed with 213c949

@dec0dOS dec0dOS closed this as completed Oct 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
new-feature New features or options.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@dec0dOS @aruznieto