Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: i18n #182

Merged
merged 8 commits into from
Oct 19, 2023
Merged

feat: i18n #182

merged 8 commits into from
Oct 19, 2023

Conversation

aruznieto
Copy link
Contributor

@aruznieto aruznieto commented Oct 16, 2023 •
edited
Loading

Add i18n capability.

Please check the type of change your PR introduces:

  • Bugfix
  • Feature
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no API changes)
  • Build-related changes
  • Documentation content changes
  • Other (please describe):

What is the current behavior?

Issue Number: #137

Does this introduce a breaking change?

  • Yes
  • No

Other information

Actually I trying to add the possibility to change the language.

dec0dOS
dec0dOS reviewed Oct 16, 2023
View reviewed changes
backend/routes/auth.js Outdated Show resolved Hide resolved
@aruznieto
Copy link
Contributor Author

aruznieto commented Oct 17, 2023 •
edited
Loading

Added settings page (no tested on a computer with a different than Spanish or English). Maybe you should consider to remove all console.logs on all platform or enable it only on debug mode, nor production

@aruznieto
Copy link
Contributor Author

aruznieto commented Oct 17, 2023 •
edited
Loading

https://crowdin.com/project/zero-ui

We can talk on Discord/Telegram if u want

@aruznieto aruznieto mentioned this pull request Oct 18, 2023
Open
9 tasks
@aruznieto aruznieto marked this pull request as ready for review October 18, 2023 08:00
dec0dOS
dec0dOS requested changes Oct 19, 2023
View reviewed changes
frontend/public/locales/en/common.json Show resolved Hide resolved
frontend/public/locales/en/common.json Outdated Show resolved Hide resolved
frontend/public/locales/en/common.json Outdated Show resolved Hide resolved
frontend/public/locales/en/common.json Outdated Show resolved Hide resolved
frontend/src/components/HomeLoggedIn/HomeLoggedIn.jsx Outdated Show resolved Hide resolved
frontend/src/components/SettingsComponent/SettingsComponent.jsx Outdated Show resolved Hide resolved
frontend/src/i18n.js Outdated Show resolved Hide resolved
frontend/src/components/SettingsComponent/SettingsComponent.jsx Outdated Show resolved Hide resolved
frontend/src/components/SettingsComponent/SettingsComponent.jsx Outdated Show resolved Hide resolved
frontend/src/routes/Settings/Settings.jsx Outdated Show resolved Hide resolved
@dec0dOS
Copy link
Owner

dec0dOS commented Oct 19, 2023

https://crowdin.com/project/zero-ui

We can talk on Discord/Telegram if u want

I would like to know more about the crowdin platform. Please share your contacts.

@dec0dOS
Copy link
Owner

dec0dOS commented Oct 19, 2023

Added settings page (no tested on a computer with a different than Spanish or English). Maybe you should consider to remove all console.logs on all platform or enable it only on debug mode, nor production

Removing the console.log statements from the frontend doesn't offer any significant benefits. ZeroUI is primarily used by administrators, not average users. Logs can be quite helpful in identifying and resolving issues, so removing them doesn't really contribute to the improvement of the platform in any way

@aruznieto
Copy link
Contributor Author

https://crowdin.com/project/zero-ui

We can talk on Discord/Telegram if u want

I would like to know more about the crowdin platform. Please share your contacts.

Same username that here. @aruznieto (tg)

@dec0dOS
Copy link
Owner

dec0dOS commented Oct 19, 2023

Same username that here. @aruznieto (tg)

Right now, I'm a bit tied up, but I'll reach out to you later

dec0dOS
dec0dOS requested changes Oct 19, 2023
View reviewed changes
Copy link
Owner

@dec0dOS dec0dOS left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some files are still missing the proper translation. Check the https://github.com/aruznieto/zero-ui/blob/i18n/frontend/src/components/NetworkSettings/components/ManagedRoutes/ManagedRoutes.jsx

frontend/public/locales/en/common.json Outdated Show resolved Hide resolved
frontend/public/locales/en/common.json Outdated Show resolved Hide resolved
dec0dOS
dec0dOS requested changes Oct 19, 2023
View reviewed changes
Copy link
Owner

@dec0dOS dec0dOS left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Screenshot 2023-10-19 at 13 58 59
Screenshot 2023-10-19 at 13 59 03
Screenshot 2023-10-19 at 13 59 11
Screenshot 2023-10-19 at 13 59 28
Screenshot 2023-10-19 at 13 59 19

@dec0dOS
Copy link
Owner

dec0dOS commented Oct 19, 2023

Screenshot 2023-10-19 at 14 01 56

@aruznieto
Copy link
Contributor Author

I think now all is done.

@dec0dOS
Copy link
Owner

dec0dOS commented Oct 19, 2023

LGTM

@dec0dOS dec0dOS merged commit 4a5f846 into dec0dOS:main Oct 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dec0dOS dec0dOS dec0dOS requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@aruznieto @dec0dOS