Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: keyboard shortcuts #185

Closed
wants to merge 5 commits into from

Conversation

aruznieto
Copy link
Contributor

Add keyboard shortcuts to interface.

Please check the type of change your PR introduces:

  • Bugfix
  • Feature
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no API changes)
  • Build-related changes
  • Documentation content changes
  • Other (please describe):

What is the current behavior?

Issue Number: #184

Does this introduce a breaking change?

  • Yes
  • No

Migration to ES6

@dec0dOS
Copy link
Owner

dec0dOS commented Oct 17, 2023

Hey @aruznieto, I wanted to express my gratitude for your pull request. I'm really impressed with your contributions. However, I noticed that you included the i18n feature in this PR. I'd like to take a closer look at the i18n feature separately before merging it into the project.

Could you please cherry-pick this specific commit (ff2218d)? You can find a guide on how to do this here: https://stackoverflow.com/questions/25955822/git-cherry-pick-a-single-commit-for-pull-request.

I admit that I may have merged #179 a bit prematurely, which has led to some unexpected errors in non-standard scenarios. The rate limiting feature could potentially disrupt legitimate users when a reverse proxy is in use. Therefore, I believe it's preferable to make rate limiting an opt-in feature rather than having it enabled by default. You can check the discussion on this issue here: #181. Thanks again for your hard work!

@aruznieto aruznieto closed this Oct 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants