Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: loading-page for suspense #187

Merged
merged 2 commits into from
Oct 20, 2023
Merged

Conversation

aruznieto
Copy link
Contributor

Pull Request type

Added a loading page for react Suspense while loading language.

Please check the type of change your PR introduces:

  • Bugfix
  • Feature
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no API changes)
  • Build-related changes
  • Documentation content changes
  • Other (please describe):

Does this introduce a breaking change?

  • Yes
  • No

@aruznieto aruznieto requested a review from dec0dOS as a code owner October 20, 2023 08:48
@dec0dOS
Copy link
Owner

dec0dOS commented Oct 20, 2023

Off topic: Did adding i18n increase the loading time? This PR LGTM, really to merge

@aruznieto
Copy link
Contributor Author

Off topic: Did adding i18n increase the loading time? This PR LGTM, really to merge

No, the time does not increase.

@dec0dOS
Copy link
Owner

dec0dOS commented Oct 20, 2023

The theme should be loaded first, so that we could use the branded colours. Made a small refactor, the i18n should be also loaded in the App, rather than in the index.

@dec0dOS dec0dOS merged commit fa1a687 into dec0dOS:main Oct 20, 2023
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants