New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revisit logic for deleting grant-authorized records when handling a permission revocation `RecordsWrite` #716

Open

Tracked by

thehenrytsai opened this issue Mar 29, 2024 · 0 comments

Labels

bug hacktoberfest testing

Contributor

thehenrytsai commented Mar 29, 2024

Revisit logic in postProcessingForCoreRecordsWrite() for deleting grant-authorized records when handling a permission revocation RecordsWrite.

It appears that there was no test for it and it does not look like the code worked:

not seeing permissionsGrantId being an index
not seeing this.dataStore being called to delete actual data
test coverage is missing for the main delete logic

The text was updated successfully, but these errors were encountered:

thehenrytsai added bug testing labels

thehenrytsai mentioned this issue

Swapped to Permissions protocol records for permission grant authorization #717

Merged

thehenrytsai added the hacktoberfest label

taniashiba mentioned this issue

🎃 Hacktoberfest Project Hub: dwn-sdk-js #806

Open

19 tasks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment