Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

error in method 2 ABNF? #34

Open
dhh1128 opened this issue Sep 22, 2021 · 1 comment
Open

error in method 2 ABNF? #34

dhh1128 opened this issue Sep 22, 2021 · 1 comment

Comments

@dhh1128
Copy link
Collaborator

dhh1128 commented Sep 22, 2021

Tagging @TelegramSam and @DenisRybas, who have each looked at this recently.

Example 2 in the spec shows ABNF for method 2. It shows that "S" is a purpose, but that services are also prefixed with an "S". Is this redundant? The regex recently submitted by Denis does not show that "S" is a valid purpose...

https://identity.foundation/peer-did-method-spec/index.html#example-2-abnf-for-peer-dids

@DenisRybas
Copy link
Contributor

I think there is a redundant "S" in the service section because if we add the "S" prefix before each service in the case of multiple services, we will not be able to decode them correctly. So I think the .S<encoded value of service header> would be correct

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants