Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Service block out of alignment with DIDComm #44

Open
brianorwhatever opened this issue Oct 13, 2022 · 2 comments
Open

Service block out of alignment with DIDComm #44

brianorwhatever opened this issue Oct 13, 2022 · 2 comments

Comments

@brianorwhatever
Copy link
Contributor

The service property for didcomm is out of alignment with the current state of didcomm
@dhh1128
Copy link
Collaborator

dhh1128 commented Oct 14, 2022

Agreed; there are some details to tweak. Updating the did method to realign it is easy. However, it may break existing implementations, so I'd like to know whether people using peer DIDs are reluctant to have the spec updated. Tagging @swcurran and @TelegramSam , who may have an opinion.

@brianorwhatever
Copy link
Contributor Author

Yeah, it will definitely break existing implementations 😅
Wondering what the best path forward is as it's impossible to align with both this and didcommv2 at the moment. I may implement it this way to interoperate more broadly. maybe we should really consider changing the service block in didcomm back to how it was originally

This was referenced Oct 15, 2022
Open
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@dhh1128 @brianorwhatever