Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

controller string should be populated to be more consistent with other DID implementations #1010

Open
troyronda opened this issue Jan 21, 2021 · 3 comments

Comments

@troyronda
Copy link
Collaborator

troyronda commented Jan 21, 2021

Re: #1009 (comment)

#1006 (comment)
@OR13 wrote:

I strongly recommend against returning the empty string for the controller property.... if makes sidetree look different than every other did method, and its not guaranteed to work accross JSON-LD implementations... the controller property should match the didDocument.id.

I agree - it is better to populate the controller property rather than leave it empty.

@thehenrytsai @OR13 @csuwildcat @sandrask @isaacJChen

@OR13
Copy link
Contributor

OR13 commented Feb 2, 2021

Is this a v1 issue?

@OR13
Copy link
Contributor

OR13 commented Feb 2, 2021

@llorllale
Copy link

This isn't a consistency issue... this is a compliance issue.

From did-core:

controller
The value of the controller property MUST be a string that conforms to the rules in § 3.1 DID Syntax.

@decentralgabe decentralgabe added this to the V1.1 milestone Feb 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants