feat: add optional HttpClient to allow mocking
#64
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ethan-tbd
requested review from
mistermoe,
kirahsapong,
wesbillman and
diehuxx
as code owners
|
will merge first, but curious to hear your opinion on this change @mistermoe |
mistermoe
reviewed
Apr 23, 2024
| @@ -60,7 +61,8 @@ class DidJwk { | |||
| /// an invalid [DidResolutionResult]. | |||
| /// | |||
| /// Throws [FormatException] if the JWK parsing fails. | |||
| static Future<DidResolutionResult> resolve(Did did) async { | |||
| static Future<DidResolutionResult> resolve(Did did, | |||
| {HttpClient? client}) async { | |||
There was a problem hiding this comment.
hmm feels odd here because not all resolvers need http clients
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
allows other functions that rely on
DidResolverto mock out thegetUrlresponses that are withinDidDhtandDidWebresolve()functions