-
Notifications
You must be signed in to change notification settings - Fork 17
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add command for creating a presentation definition #398
Add command for creating a presentation definition #398
Conversation
thanks so much! we'll review soon 🙏🏾 |
5926a66
to
fe77836
Compare
yay thank you @w3irdrobot!!! I think @bnonni was mentioning to me that you're familiar with Rust but new to the PEX game. appreciate the contribution! |
I have an ask, for these complex objects lets have an optional json input param so we can just copy paste a pd input into the command line |
@nitro-neal so the output of this command is a PD. if you already have a PD definition, then you wouldn't need to use this command. perhaps i misunderstand the ask |
@nitro-neal are there any other questions on the PR? |
Hey @nitro-neal @KendallWeihe - If there is nothing else required to close this PR as the task describes, please review, merge and close this PR and attach the |
Oh yeah my intention with this issue was to just enable people to be able to create a PD via the CLI @nitro-neal @w3irdrobot |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
really great work here, thank you @w3irdrobot!
What type of PR is this? (check all applicable)
Description
This PR adds this the
web5 pd create
command for generating presentation definitions.Related Tickets & Documents
Resolves #328
Mobile & Desktop Screenshots/Recordings
Added code snippets?
Added tests?
No tests? Add a note
Added to documentation?
No docs? Add a note
[optional] Are there any post-deployment tasks we need to perform?
No
[optional] What gif best describes this PR or how it makes you feel?