Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add command for creating a presentation definition #398

Merged
merged 1 commit into from
Oct 29, 2024

Conversation

w3irdrobot
Copy link
Contributor

What type of PR is this? (check all applicable)

  • ♻️ Refactor
  • ✨ New Feature
  • 🐛 Bug Fix
  • 📝 Documentation Update
  • 👷 Example Application
  • 🧑‍💻 Code Snippet
  • 🎨 Design
  • 📖 Content
  • 🧪 Tests
  • 🔖 Release
  • 🚩 Other

Description

This PR adds this the web5 pd create command for generating presentation definitions.

Related Tickets & Documents

Resolves #328

Mobile & Desktop Screenshots/Recordings

Added code snippets?

  • 👍 yes
  • 🙅 no, because they aren't needed

Added tests?

  • 👍 yes
  • [x 🙅 no, because they aren't needed
  • 🙋 no, because I need help

No tests? Add a note

Added to documentation?

  • 📜 readme
  • 📜 contributing.md
  • 📓 general documentation
  • 🙅 no documentation needed

No docs? Add a note

[optional] Are there any post-deployment tasks we need to perform?

No

[optional] What gif best describes this PR or how it makes you feel?

image

@angiejones
Copy link

thanks so much! we'll review soon 🙏🏾

@blackgirlbytes
Copy link
Contributor

yay thank you @w3irdrobot!!! I think @bnonni was mentioning to me that you're familiar with Rust but new to the PEX game. appreciate the contribution!

@nitro-neal
Copy link
Contributor

I have an ask, for these complex objects lets have an optional json input param so we can just copy paste a pd input into the command line

@w3irdrobot
Copy link
Contributor Author

@nitro-neal so the output of this command is a PD. if you already have a PD definition, then you wouldn't need to use this command. perhaps i misunderstand the ask

@w3irdrobot
Copy link
Contributor Author

@nitro-neal are there any other questions on the PR?

@taniashiba
Copy link
Contributor

Hey @nitro-neal @KendallWeihe - If there is nothing else required to close this PR as the task describes, please review, merge and close this PR and attach the hacktoberfest-accepted so that this contribution can count for Hacktoberfest. Hacktoberfest ends this week 🙏 Thank you so much!

@blackgirlbytes
Copy link
Contributor

Oh yeah my intention with this issue was to just enable people to be able to create a PD via the CLI @nitro-neal @w3irdrobot

Copy link
Contributor

@KendallWeihe KendallWeihe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

really great work here, thank you @w3irdrobot!

@KendallWeihe KendallWeihe merged commit d78a1eb into decentralized-identity:main Oct 29, 2024
26 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

(Feature): Add command and functionality to create a presentation definition
6 participants