Remove iframe when kernel is killed or restarted #22
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This will remove the iframe in three valid situations:
Both 2 and 3 are doable from the python side, as they kill the interpreter, and can be caught via an
atexit
hook. 1 and 2 are doable from the javascript side of the widget by listening to changes to the session status, which is not officially supported for widgets as far as I can tell, but does work. See here for example of these listeners: https://github.com/jupyter-widgets/ipywidgets/blob/main/python/jupyterlab_widgets/src/manager.ts#L427Only current downside of this approach is it will keep spawning listeners. I'm not sure if there's a good way to prune them or the widget itself completely (as even after the iframe is removed the widget is still around, with the exception of case 3).
I've tested with the following cells and verified the iframe is removed in all these cases:
Also fixes #23
Checked by copying the cells from the iframe created above