Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update JsPlugin for proper server-side support #16

Merged
merged 5 commits into from
Dec 13, 2023
Merged

Update JsPlugin for proper server-side support #16

merged 5 commits into from
Dec 13, 2023

Conversation

devinrsmith
Copy link
Member

In addition, updates JsPlugin documentation to be consistent with deephaven/deephaven-core#4925

Fixes #15

@devinrsmith
Updates JsPlugin distribution_path to root
59219ab 
In addition, updates JsPlugin documentation to be consistent with deephaven/deephaven-core#4925

Fixes deephaven#15
@devinrsmith devinrsmith self-assigned this Dec 11, 2023
mofojed
mofojed reviewed Dec 11, 2023
View reviewed changes
src/deephaven/plugin/js.py Outdated Show resolved Hide resolved
mofojed
mofojed approved these changes Dec 11, 2023
View reviewed changes
Copy link
Member

@mofojed mofojed left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, some comments on the other ticket: https://github.com/deephaven/deephaven-plugins/pull/150/files

@devinrsmith devinrsmith requested a review from mofojed December 12, 2023 17:17
@devinrsmith devinrsmith changed the title Updates JsPlugin distribution_path to root Update JsPlugin for proper server-side support Dec 12, 2023
mofojed
mofojed reviewed Dec 12, 2023
View reviewed changes
Copy link
Member

@mofojed mofojed left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm alright with it, root_path just seems redundant.

src/deephaven/plugin/js.py Outdated Show resolved Hide resolved
@devinrsmith devinrsmith requested a review from mofojed December 12, 2023 21:01
niloc132
niloc132 approved these changes Dec 13, 2023
View reviewed changes
Copy link
Member

@niloc132 niloc132 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved, one clarification: the intention w.r.t. allow/deny lists for files in path is to add a new, non-abstract method in the future as needed?

@devinrsmith
Copy link
Member Author

Approved, one clarification: the intention w.r.t. allow/deny lists for files in path is to add a new, non-abstract method in the future as needed?

If needed, yes, something like that. Or regex, glob, etc.

@devinrsmith devinrsmith merged commit 1aed15b into deephaven:main Dec 13, 2023
1 check passed
@devinrsmith devinrsmith deleted the update-js-plugin branch December 13, 2023 17:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@niloc132 niloc132 niloc132 approved these changes

@mofojed mofojed Awaiting requested review from mofojed

Assignees

@devinrsmith devinrsmith

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Finalize JsPlugin
3 participants
@devinrsmith @niloc132 @mofojed