Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ui.table respond to format prop changes #982

Open
mattrunyon opened this issue Oct 31, 2024 · 0 comments · May be fixed by #1046
Open

ui.table respond to format prop changes #982

mattrunyon opened this issue Oct 31, 2024 · 0 comments · May be fixed by #1046
Assignees
Labels
deephaven.ui enhancement New feature or request
Milestone

Comments

@mattrunyon
Copy link
Collaborator

ui.table currently does not respond to the format_ prop changing. It takes the initial value and leaves it at that.

We should probably use fast-deep-equal and make a hook to keep the value based on deep equality. That way we can respond to user changes to the format without reloading the table on every prop change.

We could create a map of if_ value to column names so we can only add/remove custom columns as necessary if any change instead of reloading the whole table on any format change.

@vbabich vbabich added this to the November 2024 milestone Nov 5, 2024
@vbabich vbabich removed the triage label Nov 5, 2024
@mattrunyon mattrunyon self-assigned this Nov 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
deephaven.ui enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants