test: Fix e2e docker writing files as root on Linux #1045
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I think this only affects Linux from what I could find online.
Essentially, Docker creates volume directories as root if the directory doesn't exist on the host machine. It also runs and writes files as root, so even if you create the directory ahead of time, the files are still owned by root. This is really annoying if you run say
npm run e2e:docker
and thennpm run e2e:ui
to start in headed mode because running outside of Docker can't write to the directories it needs to. You then need tosudo rm -r test-results playwright-report
and possibly some snapshot files at times if you change tests.This should fix all of that and offer a prompt to fix the directories if they aren't owned by you when you run with Docker. After that, snapshots should work smoothly and write all the files as your user instead of root.