-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Commit Hash in Docker Image #115
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think to move this label should only apply to edge / branch builds (using the Dockerfile split staging construct mentioned earlier). Also, does everything work if GIT_REVISION is set to an empty string instead of "not-set"
?
Also, for the release, we probably technically want to point to the tag revision and not the commit revision, if we were to add the LABEL for the release. I could probably argue we should use the tag name (as opposed to the revision SHA) for the GIT_REVISION for release images, but regardless, we would want to do that separately from this PR.
Note the difference. |
6cc660f
to
4ee94c8
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Please write a merge message describing this a bit more succinctly.
build-ci.yml
andedge-ci.yml
workflowsdocker container inspect ddb093257e90
shows output that contains"org.opencontainers.image.revision": "71646c35b2987e83cf34b53b632498b8aba21332"
curl https://api.github.com/repos/deephaven/deephaven-core/commits/v0.35.0 | grep '"sha":' | head -1 | cut -d'"' -f4