Add deephaven-plugin-ui (and other plugins) to base server image #118
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
mofojed
commented
Sep 17, 2024
mofojed
commented
- Deprecate the server-ui image, and just bake the plugins into core
- Deprecate the server-ui image, and just bake the plugins into core
devinrsmith
requested changes
Sep 22, 2024
Comment on lines
-162
to
-163
| "${REPO_PREFIX}${SERVER_PREFIX}-ui:${TAG}", | ||
| equal("latest", TAG) ? "${REPO_PREFIX}${SERVER_PREFIX}-ui:${DEEPHAVEN_VERSION}" : "" |
There was a problem hiding this comment.
We can continue producing server-ui images by just tagging the server images with these tags in the server target; I think we should prefer to do this for at least one release, at which point we can consider removing them.
README.md
Outdated
| * `ghcr.io/deephaven/server-sklearn:0.35.2` | ||
| * `ghcr.io/deephaven/server-tensorflow:0.35.2` | ||
| - `ghcr.io/deephaven/server:0.35.2` | ||
| - ~~`ghcr.io/deephaven/server-ui:0.35.2`~~ **Deprecated.** Use `ghcr.io/deephaven/server:0.35.2` instead. |
There was a problem hiding this comment.
We should only mark it as deprecated after the next release.
Add -ui tag to to the server images
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.