Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DHE: Python Language Server #156

Open
bmingles opened this issue Oct 15, 2024 · 1 comment
Open

DHE: Python Language Server #156

bmingles opened this issue Oct 15, 2024 · 1 comment
Assignees
Labels
enhancement New feature or request
Milestone

Comments

@bmingles
Copy link
Collaborator

bmingles commented Oct 15, 2024

The vscode extension needs to be able to use a language server running on the server in the context of the Core+ worker.

  • Extension needs to talk to language service specific to the Core+ worker the editor is running against
  • There are certain global objects available to Python scripts. These should show up in intellisense
  • What to do when worker is not connected?
  • DHE: Workspace dependencies #105 is related and should probably be addressed via the LSP

Notes
We have a LSP implementation that can be used as a starting point:

https://github.com/deephaven-ent/iris/blob/b10dd884acd3deae810ca85d391b029ee655d95b/web/client-api/src/main/java/com/illumon/iris/ide/shared/IdeSession.java#L141

We might also consider a stop gap solution for this by providing a requirements.txt to the user to mirror their local env with the server. This would get around the need to have access to the server's language service.
Related docs:

@bmingles bmingles added enhancement New feature or request triage labels Oct 15, 2024
@bmingles bmingles self-assigned this Oct 15, 2024
@vbabich vbabich added this to the November 2024 milestone Oct 15, 2024
@vbabich vbabich removed the triage label Oct 15, 2024
@mofojed
Copy link
Member

mofojed commented Nov 1, 2024

Here's a way for setting up a local venv that matches a worker on the server:
https://deephaven.io/enterprise/docs/development/installing-python/#create-a-local-python-venv
I think that may be with a legacy workers, but something similar to that would be a good workaround for setting up a venv similar to your Core+ worker before completing language server, with little work.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

4 participants