Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Update connection status on disconnect #176

Merged
merged 1 commit into from
Nov 18, 2024

Conversation

bmingles
Copy link
Collaborator

@bmingles bmingles commented Nov 14, 2024

  • Connection status wasn't updating on disconnect editor / server (I added comments to the 2 new lines that fixed this)
  • Moved connection related commands + handlers to ConnectionController. This should be the rest of the code. Just moving existing functionality.

Testing

  • Run a script against a server to create connection + associate editor
  • Status bar item should update to show the server the active editor is connected to
  • In the "CONNECTIONS" panel, click the split plug icon beside the editor node to "Disconnect Editor"
  • Status bar item should update to "Deephaven: Disconnected"
  • Repeat but instead of "Disconnect Editor", click the "Disconnect from Server" icon in the "SERVERS" panel (the split plug beside the server node)

*/
onDisconnectEditor = (uri: vscode.Uri): void => {
this._serverManager?.disconnectEditor(uri);
this.updateConnectionStatusBarItem();
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This fixes the issue of status not updating on editor disconnect.

);
}

this.updateConnectionStatusBarItem();
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This fixes issue of connection status not updating on server disconnect.

Copy link

github-actions bot commented Nov 14, 2024

End-to-end Test Summary

Tests 📝Passed ✅Failed ❌Skipped ⏭️Pending ⏳Other ❓Flaky 🍂Duration ⏱️
660000004:57:42
A ctrf plugin

Detailed Test Results

NameStatusmsFlaky 🍂
should default to the correct settingspassed ✅1912
should return custom settings: Empty configspassed ✅303
should return custom settings: Populated configspassed ✅129
should be able to load VSCodepassed ✅875
should only be visible when a supported file type is active: test.groovypassed ✅2770
should only be visible when a supported file type is active: test.pypassed ✅958
A ctrf plugin

Failed Test Summary

No failed tests ✨

Flaky Test Summary

No flaky tests detected. ✨

@bmingles bmingles linked an issue Nov 14, 2024 that may be closed by this pull request
@bmingles bmingles requested a review from mofojed November 14, 2024 20:41
mofojed
mofojed previously approved these changes Nov 18, 2024
@bmingles bmingles force-pushed the 101-connection-status-fixes branch from 75610a8 to 8325b0b Compare November 18, 2024 22:37
@bmingles bmingles merged commit 6be6d89 into main Nov 18, 2024
3 checks passed
@bmingles bmingles deleted the 101-connection-status-fixes branch November 18, 2024 22:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Reconnecting via click is impossible
2 participants