ci: CI Testing #57
ci: CI Testing #57
Conversation
bmingles
force-pushed
the
29-tests
branch
4 times, most recently
from
e1b3a65 to
7577bf5
Compare
| @@ -1,5 +1,13 @@ | |||
| { | |||
| "singleQuote": true, | |||
| "trailingComma": "es5", | |||
| "arrowParens": "avoid" | |||
| "arrowParens": "avoid", | |||
| "overrides": [ | |||
There was a problem hiding this comment.
Apparently newer versions of Prettier add trailing commas to jsonc files which is not always supported.
There was a problem hiding this comment.
I think this applies to .json files as well, no? I know package.json is not happy if you add a trailing comma
bmingles
force-pushed
the
29-tests
branch
2 times, most recently
from
cd8ab97 to
1f1103c
Compare
bmingles
force-pushed
the
29-tests
branch
2 times, most recently
from
ea2cb82 to
a509b03
Compare
End-to-end Test Summary
Detailed Test Results
Failed Test SummaryNo failed tests ✨Flaky Test SummaryNo flaky tests detected. ✨ |
Unit Test Summary
Detailed Test Results
Failed Test SummaryNo failed tests ✨Flaky Test SummaryNo flaky tests detected. ✨ |
… on jsonc files (#29)
| @@ -1,5 +1,13 @@ | |||
| { | |||
| "singleQuote": true, | |||
| "trailingComma": "es5", | |||
| "arrowParens": "avoid" | |||
| "arrowParens": "avoid", | |||
| "overrides": [ | |||
There was a problem hiding this comment.
I think this applies to .json files as well, no? I know package.json is not happy if you add a trailing comma
CONTRIBUTING.md
Outdated
|
|
||
| ### Unit Testing | ||
|
|
||
| TODO: |
There was a problem hiding this comment.
TODO - fill in or write a ticket
There was a problem hiding this comment.
Yes, the prettierrc thing does apply to json, but that already works as expected. The issue here is that prettier incorrectly adds trailing commas to jsonc. It doesn't do that for json
| "test": "npm run ts:build && npm run ts:check && npm run test:lint && npm run test:unit", | ||
| "test:ci": "npm run test", | ||
| "test": "npm run test:unit", | ||
| "test:ci": "npm run ts:build && npm run ts:check && npm run test:lint && npm run test:unit", |
There was a problem hiding this comment.
Should consider using concurrently, though this works.
resolves #29