Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The feature reverting with message is not working yet #177

Open
kalloc opened this issue Dec 18, 2022 · 1 comment
Open

The feature reverting with message is not working yet #177

kalloc opened this issue Dec 18, 2022 · 1 comment

Comments

@kalloc
Copy link

kalloc commented Dec 18, 2022

Describe the bug

Sometimes, I need to make fake revert. For example, when I write tests for uniswap family contracts or another contracts based on nested calls. But I can't make fake revert with custom message using smock.
Please, help me to understand what I did wrong.

Reproduction steps

To simplify reproduction, I made a repo https://github.com/kalloc/smock-reverts-bug

Expected behavior
I expected to have an ability to fake revert with custom message

Screenshots

image

System Specs:

@0xmichalis
Copy link

This is quite limiting as we cannot unit test error handling of external calls.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants