Skip to content
This repository has been archived by the owner on Oct 28, 2024. It is now read-only.

Kaiser continues when it can't bind to host's ports #54

Open
thoiberg opened this issue May 29, 2020 · 0 comments
Open

Kaiser continues when it can't bind to host's ports #54

thoiberg opened this issue May 29, 2020 · 0 comments

Comments

@thoiberg
Copy link

thoiberg commented May 29, 2020

When a different docker environment is running and is bound to the same ports that Kaiser is trying to use when it starts, it logs a message and fails to bind the ports for that particular container. However, it then continues with the rest of the setup. This can result in confusing error messages as later steps in the process are assuming that the container was bound successfully.

A possible improvement for this would be for kaiser to fail if the container cannot be bound, and notify the user that the required port is in use and that they need to stop whatever is using that port and retry kaiser again.

Example of how kaiser handles attempting to bind to a port already in use. The error message doesn't really stand out and can easily get buried in the rest of the output text:

docker: Error response from daemon: driver failed programming external connectivity on endpoint nginx (f561316244b4db5830ff146df9b50b25b444ed7aff158081595e895663ec0476): Bind for 0.0.0.0:443 failed: port is already allocated.

# continues on with the rest of the process...

How to replicate

  1. Start a separate docker container and bind it to the same port as one that Kaiser will try to use
  2. start Kaiser
  3. Note a similar error message as the one above and that kaiser continues with the rest of the process
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant