Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Explicitly set Invoke Return Variable #57

Merged
merged 2 commits into from
Mar 9, 2023
Merged

Explicitly set Invoke Return Variable #57

merged 2 commits into from
Mar 9, 2023

Conversation

McOso
Copy link

@McOso McOso commented Mar 9, 2023

Related to #7

Problem: Compile warning

warning[5667]: Warning: Unused function parameter. Remove or comment out the variable name to silence this warning.
   --> lib/delegatable-sol/contracts/Delegatable.sol:128:18:
    |
128 |         returns (bool success)
    |                  ^^^^^^^^^^^^

Solution: Explicitly set the success return variable of all external invoke functions.

Change increases gas consumption for the invoke function by 3

del-diff

@danfinlay
Copy link

Looks fine to me!

@danfinlay danfinlay merged commit 2e2a6ca into delegatable:main Mar 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants