You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
For deno vendor, it might be nice to have a way to represent /// <reference types="..." /> and x-TypeScript-types separately in the graph while still providing a common method for the maybe_types_dependency.
This would also help us remove Range from being necessary for x-typescript-types as the types directive could have a range, but the x-typescript-types doesn't need one:
I don't think they should specifically be seperate, as they represent the same functional concept, but should contain an optional range instead of a 0 range.
dsherret
changed the title
Store types directive and x-TypeScript-types separately in the graph
Ability to discern between types directive and x-TypeScript-types
Feb 10, 2022
For
deno vendor
, it might be nice to have a way to represent/// <reference types="..." />
andx-TypeScript-types
separately in the graph while still providing a common method for themaybe_types_dependency
.This would also help us remove
Range
from being necessary forx-typescript-types
as the types directive could have a range, but thex-typescript-types
doesn't need one:deno_graph/src/graph.rs
Lines 1331 to 1340 in f8adbe4
Alternatively, I can just do a check for the start and end position all being zero, but that seems a little hacky.
The text was updated successfully, but these errors were encountered: