Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Need mechanism for tests ordering (execute L1 tests at the end) #242

Open
StepanVovkPLV opened this issue Apr 6, 2023 · 4 comments · May be fixed by #243
Open

Need mechanism for tests ordering (execute L1 tests at the end) #242

StepanVovkPLV opened this issue Apr 6, 2023 · 4 comments · May be fixed by #243
Assignees

Comments

@StepanVovkPLV
Copy link
Contributor

StepanVovkPLV commented Apr 6, 2023

Issue: with L1 tests we facing issue of changing port(s) speed, duplex etc. In order to get device to pretest condition we rebooting device.
To save time on tests run decided to reboot device on the last test within the L1 tests in the session.

We see two solution to reboot device on the last test :

  1. Modifying conftest.py like in the draft PR -> Reboot device after L 1 tests #243
  2. Bring pytest-order library which supports session-, module- and class-scope ordering via the order-scope option . But hesitate to bring new library if we ever use it just for L1 tests

@mgheorghe can you please advice.

@yuriilisovskyi yuriilisovskyi changed the title Tests order with L1 tests Need mechanism for tests ordering (execute L1 tests at the end) Apr 6, 2023
@yuriilisovskyi yuriilisovskyi linked a pull request Apr 6, 2023 that will close this issue
@yuriilisovskyi
Copy link
Collaborator

@mgheorghe could you please review this issue and PR? It is related to Phase1 tests, would be nice to have

@mgheorghe
Copy link
Contributor

i thought that each island can be ran individually and can be ordered by triggering a run on island 1 to 7 and then trigger run with island 11,
so this can be controlled from the bash script

@yuriilisovskyi
Copy link
Collaborator

Actually, we run the tests by triggering run of functional test suite group. And tests collection is handled by pytest which has no direct way to set tests order for our case.
So, we either need to add pytest-order package that can solve the issue or modify the tests collection flow in the framework.

@StepanVovkPLV
Copy link
Contributor Author

StepanVovkPLV commented Jul 19, 2023

Hi @mgheorghe
We have already solution for this issue by implementing fixture here which reverts port configuration to default. Do we need to keep solution in this PR #243? If not, I would suggest closing this issue and PR

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants