Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

LEAF-4487 - Large Queries #11

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

shaneodd
Copy link
Contributor

Moving the test over here from the old x-test dir in leaf

This is the test that works with this pr, it should still work with the current master branch.

department-of-veterans-affairs/LEAF#2546

Copy link
Collaborator

@mgaoVA mgaoVA left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These tests should be moved into the formQuery_test.go file, since it's testing api/form/query.

The test should not be made "compatible" with the master branch -- since we're looking for a specific header to determine success, the absence of the header must indicate failure. Explaining that the test only works with a specific PR (which you've already done) would be sufficient. Maybe we can also create a label in Github to highlight this distinction.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants