Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Gain agreement on proposed data model changes for Vet Center CAP data #13613

Open
2 of 5 tasks
kmariepat-cityfriends opened this issue May 4, 2023 · 7 comments
Open
2 of 5 tasks
Labels
Blocked Issues that are blocked on factors other than blocking issues. Drupal engineering CMS team practice area Facilities Facilities products (VAMC, Vet Center, etc) ghp-backlog Lighthouse Facility API Data source/destination for many Facilities team products points-8 sitewide Vet Center CMS managed product owned by Facilities team

Comments

@kmariepat-cityfriends
Copy link

kmariepat-cityfriends commented May 4, 2023

Background

Review the following cards for past work done on determining this model:

Acceptance Criteria

  • I expect changes are made to the CAP data model to have parity with the model outlined in this card: CMS - Lighthouse: push more facility service data #4769
  • Align with Lighthouse about the proposed data model determined in the above AC
  • Align with Lighthouse about send method for CAP data (this card does not include creating that end point which is created by Lighthouse)
  • Gain agreement with Lighthouse about lat/long:
  • Do we push if we have no lat/long; I expect that we can not push if the lat lon is not present and that we can not publish the node if the lat lon is not provided.
    (if no geo-coordinates it wouldn't be valid with the lighthouse data model)
  • Do we push CAPS with unpublished data? I expect that we do not push if the node is not published.
    (this differs from other node, in this case the node is the source of truth of everything and the CAP is not launched until it is published)

  • Shutting down a CAP?
  • I expect the lighthouse team confirms the endpoint approach with the facilities dev working on this card
    add, update and delete endpoint?
    OR one endpoint?
    OR something else
@kmariepat-cityfriends kmariepat-cityfriends added the Facilities Facilities products (VAMC, Vet Center, etc) label May 4, 2023
@davidmpickett davidmpickett added Vet Center CMS managed product owned by Facilities team Lighthouse Facility API Data source/destination for many Facilities team products labels May 4, 2023
@swirtSJW swirtSJW self-assigned this May 12, 2023
@swirtSJW
Copy link
Contributor

Delivered to Lighthouse for review here https://dsva.slack.com/archives/C02BTJTDFTN/p1684729527218149

@swirtSJW
Copy link
Contributor

This is now waiting on Lighthouse to review usability of field names

@jilladams jilladams added the Drupal engineering CMS team practice area label May 30, 2023
@jilladams
Copy link
Contributor

Notes from 6/5 lighthouse meeting re: status:

  • Swirt pushed sample data in progress, over the weekend, Adam is taking a look currently
    • Also looking for better field name, work with Dana
  • Need lighthouse to determine the end-point approach for update/add/delete of CAPs (Likely Adam)
    • Schema was proposed a while ago, at any point we can act on enacting that schema
      ^^ These tasks will satisfy this ticket.

Still identified as a post-V1 effort. Ticket will roll to Sprint 86.

@jilladams jilladams added the Blocked Issues that are blocked on factors other than blocking issues. label Sep 27, 2023
@swirtSJW
Copy link
Contributor

This is the new PR from the branch. #16837
It is largely feature complete pending Lighthouse giving us an actual endpoint and coordinating / testing with LH.

@Agile6MSkinner
Copy link

@davidmpickett @omahane Is this dead now that swirt is gone or should we revive it?

@davidmpickett
Copy link
Contributor

I think that this is a still a when, not an if, question.

I'm not sure if this is an example of something that is possible on Lighthouse Facilities API v1 that wasn't possible on v0 and just hasn't been prioritized, or if it's blocked until Lighthouse v2. Either way, it's a core piece of the long term strategy for Facilities data. The PR may be stale, but the work is still relevant and has high Veteran value. It would enable surfacing about ~450 facilities in Facility Locator.

The approach here will likely also inform the #15366 as they both involve making Drupal the source of truth for Lighthouse of basic facility data (currently we're only source of truth to them for operating status and service details)

I haven't been super looped in to the Lighthouse convos, others can probably give a more accurate recap of the blockers/ next steps

@jilladams
Copy link
Contributor

Card for this in the Lighthouse sync board: https://trello.com/c/ciZEObA6/1-vet-center-community-access-point-push-receive-partially-blocked-on-endpoint. Blocked on Lighthouse capacity to pick it up / define the endpoint we will push to.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Blocked Issues that are blocked on factors other than blocking issues. Drupal engineering CMS team practice area Facilities Facilities products (VAMC, Vet Center, etc) ghp-backlog Lighthouse Facility API Data source/destination for many Facilities team products points-8 sitewide Vet Center CMS managed product owned by Facilities team
Projects
None yet
Development

No branches or pull requests

5 participants