Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

error: expected comma after minor version number, found '-' #114

Open
cberner opened this issue Jun 28, 2021 · 1 comment
Open

error: expected comma after minor version number, found '-' #114

cberner opened this issue Jun 28, 2021 · 1 comment
Assignees
Labels
bug Something isn't working

Comments

@cberner
Copy link

cberner commented Jun 28, 2021

I use deps.rs with my project https://github.com/fleetfs/fleetfs, and the badge has been failing. I ran deps.rs locally and found that the error message is "error: expected comma after minor version number, found '-'".

I haven't been able to determine the cause of this, but I created a minimal repro: https://github.com/cberner/depsrs-bug, which you can see fail: https://deps.rs/repo/github/cberner/depsrs-bug

@paolobarbolini paolobarbolini self-assigned this Jun 28, 2021
@paolobarbolini paolobarbolini added the bug Something isn't working label Jun 28, 2021
@paolobarbolini
Copy link
Member

paolobarbolini commented Jun 28, 2021

Thanks for taking the time to create a minimal repro.

The issue is with semver 1.0 tightening it's rules to only support cargo's interpretation of semantic versioning. raft 0.5.0 specified an invalid version requirement for protobuf, and because deps.rs parses all releases of a crate, querying any raft version fails because of 0.5.0 having the semver issue.

This issue has already happened multiple times in the past rust-lang/crates.io#2463, so deps.rs will have to change in order to ignore bad releases instead of failing the entire dependency tree analysis.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants