Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: revise postgres permission setup instructions. #10039

Merged
merged 2 commits into from
Oct 10, 2024

Conversation

ioga
Copy link
Contributor

@ioga ioga commented Oct 10, 2024

Description

Since pg15, you need to explicitly grant access on public schema.
I remember some people hit the same issue in older postgres versions as well when using external/custom postgres installations with special permissions.

https://determined-community.slack.com/archives/CV3MTNZ6U/p1728583301953569?thread_ts=1728510027.402639&cid=CV3MTNZ6U

Test Plan

N/A

Checklist

  • Changes have been manually QA'd
  • New features have been approved by the corresponding PM
  • User-facing API changes have the "User-facing API Change" label
  • Release notes have been added as a separate file under docs/release-notes/
    See Release Note for details.
  • Licenses have been included for new code which was copied and/or modified from any external code

@cla-bot cla-bot bot added the cla-signed label Oct 10, 2024
@ioga ioga requested a review from stoksc October 10, 2024 18:07
@determined-ci determined-ci requested a review from a team October 10, 2024 18:07
@determined-ci determined-ci added the documentation Improvements or additions to documentation label Oct 10, 2024
@@ -123,6 +123,7 @@ Install PostgreSQL using ``apt`` or ``yum``
postgres=# CREATE DATABASE determined;
postgres=# CREATE USER determined WITH ENCRYPTED PASSWORD 'determined-password';
postgres=# GRANT ALL PRIVILEGES ON DATABASE determined TO determined;
postgres=# GRANT ALL ON SCHEMA public TO determined;
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If you don't switch to the determined database, don't you need to qualify this grant? Or switch first?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ah, that's just me not paying enough attention

@stoksc
Copy link
Contributor

stoksc commented Oct 10, 2024

fyi, we use a few other schemas besides public (but only for enterprise features).

@stoksc
Copy link
Contributor

stoksc commented Oct 10, 2024

oh, duh, this is for pg15 changes. got it.

@ioga ioga merged commit 0613cc6 into determined-ai:main Oct 10, 2024
61 of 67 checks passed
@ioga ioga deleted the docs-pg-schema branch October 10, 2024 19:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla-signed documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants