Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: Deepspeed trainer docs #10163

Closed
wants to merge 1 commit into from
Closed

chore: Deepspeed trainer docs #10163

wants to merge 1 commit into from

Conversation

MikhailKardash
Copy link
Contributor

@MikhailKardash MikhailKardash commented Oct 31, 2024 •
edited by jira bot
Loading

Ticket

None

Description

  1. Add docs for deepspeed trainer
  2. Fix a bug with the DCGAN example

Test Plan

Try DCGAN

Checklist

  • Changes have been manually QA'd
  • New features have been approved by the corresponding PM
  • User-facing API changes have the "User-facing API Change" label
  • Release notes have been added as a separate file under docs/release-notes/
    See Release Note for details.
  • Licenses have been included for new code which was copied and/or modified from any external code

@MikhailKardash MikhailKardash requested a review from a team as a code owner October 31, 2024 00:32
@cla-bot cla-bot bot added the cla-signed label Oct 31, 2024
@codecov Codecov
Copy link

codecov bot commented Oct 31, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 58.46%. Comparing base (983a8ab) to head (66238ed).
Report is 10 commits behind head on scr-docs.

Additional details and impacted files 
@@             Coverage Diff              @@
##           scr-docs   #10163      +/-   ##
============================================
+ Coverage     54.26%   58.46%   +4.20%     
============================================
  Files          1259      754     -505     
  Lines        157276   104292   -52984     
  Branches       3642     3641       -1     
============================================
- Hits          85344    60978   -24366     
+ Misses        71799    43181   -28618     
  Partials        133      133
Flag Coverage Δ
backend 43.80% <ø> (-2.11%) ⬇️
harness 71.15% <ø> (ø)
web 54.29% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
harness/determined/pytorch/deepspeed/_trainer.py 49.54% <ø> (ø)

... and 505 files with indirect coverage changes

@determined-ci determined-ci requested a review from a team October 31, 2024 00:32
@determined-ci determined-ci added the documentation Improvements or additions to documentation label Oct 31, 2024
@netlify Netlify
Copy link

netlify bot commented Oct 31, 2024 •
edited
Loading

✅ Deploy Preview for determined-ui ready!

Name Link
🔨 Latest commit 41a2cb3
🔍 Latest deploy log https://app.netlify.com/sites/determined-ui/deploys/6722d02cfddb0000085274b2
😎 Deploy Preview https://deploy-preview-10163--determined-ui.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@azhou-determined azhou-determined changed the base branch from main to scr-docs October 31, 2024 14:05
@MikhailKardash
Copy link
Contributor Author

Closing, changes in this PR are included in #10182

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@azhou-determined azhou-determined Awaiting requested review from azhou-determined azhou-determined was automatically assigned from determined-ai/model-dev

Assignees
No one assigned
Labels
cla-signed documentation Improvements or additions to documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@MikhailKardash @determined-ci