Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add an option to show the version of the CLI #145

Closed
tschaffter opened this issue Aug 28, 2022 · 3 comments
Closed

Add an option to show the version of the CLI #145

tschaffter opened this issue Aug 28, 2022 · 3 comments
Assignees
Labels
bug Something isn't working verified

Comments

@tschaffter
Copy link

I wanted to report the version of the CLI installed in my environment in another ticket, then realized that the option --version is not implemented.

$ devcontainer --version
Specify a command
devcontainer <command>

Commands:
  devcontainer open [path]   Open a dev container in VS Code
  devcontainer build [path]  Build a dev container image

Options:
  -h, --help               Show help  [boolean]
      --disable-telemetry  Disable telemetry  [boolean] [default: false]
@joshspicer
Copy link
Member

It appears you have the older 'vscode devcontainer CLI' installed on your machine. Despite the name it is not the same as the source code in this repo.

I suggest removing that command and installing the CLI from this repository. You can do so with npm:

npm install -g @devcontainers/cli

We're aware that two tools with the same name is confusing. I imagine the goal is to either remove the "vscode devcontainer CLI" completely, or forward commands to a vscode-specific build of the OSS CLI (this repo).

@bamurtaugh @chrmarti @Chuxel - We should do something about this to avoid future confusion :)

@bamurtaugh
Copy link
Member

Thanks for the tag @joshspicer and for opening this issue @tschaffter!

@alexdima and @chrmarti have been working on forwarding from the previous devcontainer CLI to the new OSS devcontainer CLI.

The built-in CLI devcontainer (or devcontainer-insiders for VS Code Insiders) of the Remote-Containers extension now forwards to the built-in open source CLI. The open command and the previous CLI arguments for the build command are also supported.

@chrmarti @alexdima is there another scenario we'll still need to cover where users may install / use the older CLI in another way (not from Remote-Containers)?

@chrmarti
Copy link
Contributor

chrmarti commented Sep 6, 2022

There is a --version option now, but I need to fix where it looks up the version (currently goes to the extension's package.json, but we want the CLI's package.json to be used).

@chrmarti chrmarti self-assigned this Sep 6, 2022
@chrmarti chrmarti added the bug Something isn't working label Sep 6, 2022
@chrmarti chrmarti added this to the September 2022 milestone Sep 6, 2022
@chrmarti chrmarti closed this as completed Sep 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working verified
Projects
None yet
Development

No branches or pull requests

6 participants
@tschaffter @rzhao271 @chrmarti @joshspicer @bamurtaugh and others