Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fragment handling for hash bang URLs #11

Open
lxbarth opened this issue May 24, 2011 · 0 comments
Open

Fragment handling for hash bang URLs #11

lxbarth opened this issue May 24, 2011 · 0 comments

Comments

@lxbarth
Copy link
Collaborator

lxbarth commented May 24, 2011

I just pushed a fix to fragment handling for hash bang URLs : 45becbc

Basically two things were broken:

  • the override to Backbone.history.saveLocation()
  • getFragment() stripped out the ! leading to mismatches of same URLs in checkUrl() (!/path != /path)

The fix brings extensive overrides to backbone which I'd rather avoid. The messiness stems from the fact that with hash bang (#!) URLs what's in the browser history (!/path) is different from the actual routes (/path) and thus non-JS fallbacks (http://example.com/path).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant