Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bones 2.x doesn't support this.$ #27

Closed
tmcw opened this issue Aug 9, 2011 · 3 comments · May be fixed by #65
Closed

bones 2.x doesn't support this.$ #27

tmcw opened this issue Aug 9, 2011 · 3 comments · May be fixed by #65

Comments

@tmcw
Copy link
Contributor

tmcw commented Aug 9, 2011

These lines should be equivalent in Backbone:

this.$('.share-embed'); 
$('.share-embed', this.el);

But the this.$ form fails with https://gist.github.com/1134286
@AdrianRossouw
Copy link

this works in my fork

the recommended way it to use the this.$el cached jquery element tho.

@lxbarth
Copy link
Collaborator

lxbarth commented May 23, 2012

@Vertice - is there a patch/pull request for this?

@AdrianRossouw
Copy link

i can make one, but there's a whole bunch of changes (new underscore, new backbone, new jquery) that kind of build on each other.

@makara makara mentioned this issue Sep 17, 2012
Open
@tmcw tmcw closed this as completed Jan 29, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Upgrade backbone to at least 0.9.2
3 participants
@tmcw @lxbarth @AdrianRossouw