We read every piece of feedback, and take your input very seriously.
To see all available qualifiers, see our documentation.
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Using the documentations readme example
<template name=developer> <!-- `{nickname}` will bind to `context` property `nickname` --> <h1>{nickname}</h1> </template>
const template = Template `developer` , context = { nickname: 'That Beast' } template.bind (context)
Is failing in current build in Chrome 110
snugsi.js:1 Uncaught TypeError: Failed to execute 'selectNodeContents' on 'Range': parameter 1 is not of type 'Node'.
I believe this is because the parameters returned to the Template Literal is actually an array so the typeof == 'string' condition never occurs.
typeof == 'string'
snuggsi/dist/snuggsi.js
Line 286 in 88242cc
If you inspect with a breakpoint you can see the parameter actually looks like this
['developer', raw: Array(1)]
This is because it is also being passed the raw strings https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Template_literals#raw_strings
As pointed out in #222 this can also be solved by changing the syntax to
const template = Template(`developer`)
However this would require updating the readme if you want to require the parens.
Alternatively the logic could be updated to ducktype like
if (t.raw) { t = document.querySelector("template[name=" + t[0] + "]") }
The text was updated successfully, but these errors were encountered:
No branches or pull requests
Using the documentations readme example
Is failing in current build in Chrome 110
I believe this is because the parameters returned to the Template Literal is actually an array so the
typeof == 'string'
condition never occurs.snuggsi/dist/snuggsi.js
Line 286 in 88242cc
If you inspect with a breakpoint you can see the parameter actually looks like this
This is because it is also being passed the raw strings
https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Template_literals#raw_strings
As pointed out in #222 this can also be solved by changing the syntax to
However this would require updating the readme if you want to require the parens.
Alternatively the logic could be updated to ducktype like
The text was updated successfully, but these errors were encountered: