Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Error getting song metainfo, no album art next to player controls #671

Open
kozross opened this issue Jun 20, 2017 · 1 comment
Open

Error getting song metainfo, no album art next to player controls #671

kozross opened this issue Jun 20, 2017 · 1 comment

Comments

@kozross
Copy link

kozross commented Jun 20, 2017

I just set up CherryMusic, and put one album into the folder for testing purposes. The files are all Ogg Vorbis (extension .ogg), and I have vorbis-tools installed. However, every time I bring up the album in the web player, I get the 'error getting song metainfo' message in the browser. In the terminal, I get the following traceback:

Traceback (most recent call last):
  File "/usr/lib/python3.6/site-packages/cherrypy/_cprequest.py", line 670, in respond
    response.body = self.handler()
  File "/usr/lib/python3.6/site-packages/cherrypy/lib/encoding.py", line 220, in __call__
    self.body = self.oldhandler(*args, **kwargs)
  File "/usr/lib/python3.6/site-packages/cherrypy/_cpdispatch.py", line 60, in __call__
    return self.callable(*self.args, **self.kwargs)
  File "/usr/lib/python3.6/site-packages/cherrymusicserver/httphandler.py", line 295, in api
    return json.dumps({'data': handler(**handler_args)})
  File "/usr/lib/python3.6/site-packages/cherrymusicserver/httphandler.py", line 715, in api_getsonginfo
    return json.dumps(metainfo.getSongInfo(abspath).dict())
  File "/usr/lib/python3.6/site-packages/cherrymusicserver/metainfo.py", line 58, in getSongInfo
    tag = TinyTag.get(filepath)
  File "/usr/lib/python3.6/site-packages/tinytag/tinytag.py", line 105, in get
    tag.load(tags=tags, duration=duration, image=image)
  File "/usr/lib/python3.6/site-packages/tinytag/tinytag.py", line 126, in load
    self._determine_duration(self._filehandler)
  File "/usr/lib/python3.6/site-packages/tinytag/tinytag.py", line 672, in _determine_duration
    self.duration = self._max_samplenum / float(self.samplerate)
TypeError: float() argument must be a string or a number, not 'NoneType'

Additionally, the album art is not displaying in the player UI (next to the playback controls), although in the folder view, I can see it just fine. Am I missing something critical here?

@devsnd
Copy link
Owner

devsnd commented Jul 21, 2017

hey @kozross,

I seem to have missed this issue, dang, sorry. Can you please send me the failing file in question to my email adress tomwallroth [aŧ] gmail [døt] com ?

This is actually an error in https://github.com/devsnd/tinytag the audio meta data parser I wrote for CherryMusic.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants