Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rework the error boundary to be more appropriate post 331 #1170

Open
ollibowers opened this issue Jul 30, 2024 · 0 comments · May be fixed by #1191
Open

rework the error boundary to be more appropriate post 331 #1170

ollibowers opened this issue Jul 30, 2024 · 0 comments · May be fixed by #1191
Assignees
Labels
📝 bug 🐛 Something isn't working 👤 closed for help 👥 Closed to external help, team only 🫣 331 🤫 Is only in scope within the current 331 branch

Comments

@ollibowers
Copy link
Collaborator

ollibowers commented Jul 30, 2024

Historically when user data was stored on the frontend, it would often get into illegal states. This is why the error boundary featured two buttons; those being a reset user data, and a ignore and return.

Nowadays, if user data gets into an illegal state, that is REALLY BAD, so we no longer want to just reset the user straight away. Instead, create three buttons:

  • back to circles (instead send them back to landing page)
  • logout (which logs them out and sends them back to
  • reset (resets redux state and sends a reset user POST request)

Also, rework the error boundary to first tell them to try refresh the current page, and if it persists, send a screenshot to us.
Would be also good to get some more helpful information on the screen (currently just displays the error as string):

  • display the full user data (if it exists)
  • display the full redux state (if possible)

Feel free to wait for salinas JSON ticket to be finished for the user data display part.

  • (can use the export buttons on the error boundary)
@ollibowers ollibowers added 📝 bug 🐛 Something isn't working 👤 closed for help 👥 Closed to external help, team only 🫣 331 🤫 Is only in scope within the current 331 branch labels Jul 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
📝 bug 🐛 Something isn't working 👤 closed for help 👥 Closed to external help, team only 🫣 331 🤫 Is only in scope within the current 331 branch
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants