Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[BUG] Bitcoin sending doesn't work #3480

Open
DeLemonCH opened this issue Nov 12, 2024 · 10 comments
Open

[BUG] Bitcoin sending doesn't work #3480

DeLemonCH opened this issue Nov 12, 2024 · 10 comments
Assignees
@StefanBerger-DFINITY
Labels
bug Something isn't working

Comments

@DeLemonCH
Copy link

DeLemonCH commented Nov 12, 2024 •
edited
Loading

Several bugs:

  1. When still in status confirmation, then there is a strange error message when calculating the fee (see first picture)
  2. Max auto-input button/click of amount is not working
  3. Sending is not working - ending with an error message (see second picture)
btc_still_in_confirmation btc_sending
@DeLemonCH DeLemonCH added the bug Something isn't working label Nov 12, 2024
@DeLemonCH
Copy link
Author

DeLemonCH commented Nov 14, 2024 •
edited
Loading

@AntonioVentilii any feedback regarding this - I think a small fix in the frontend is needed for serialization

Merged
@DenysKarmazynDFINITY
Copy link
Contributor

Hi @DeLemonCH , thanks a lot for reporting these issues! The serialization error has been identified and corrected, the fix will be available in the next release (v0.9.4). The other two points have also been noted and will be addressed soon.

DenysKarmazynDFINITY added a commit that referenced this issue Nov 14, 2024
@DenysKarmazynDFINITY
fix(frontend): use jsonReplacer to stringify bigints (#3569)
6d62bff 
# Motivation

The PR fixes one of the issues reported in
#3480. Also, I noticed a
few more places where the same kinda of error could have appeared.
@DeLemonCH
Copy link
Author

Thank you!

@StefanBerger-DFINITY StefanBerger-DFINITY self-assigned this Nov 15, 2024
@StefanBerger-DFINITY
Copy link

Hi @DeLemonCH . We filed the remaining 2 issues, and will add them into one of our next sprints.
Thanks again for filing these items!

@DeLemonCH
Copy link
Author

DeLemonCH commented Nov 21, 2024 •
edited
Loading

Hi guys, I can't still not get my Bitcoins out - now because another issue with the funds ...
Thanks for checking!
image

@DeLemonCH
Copy link
Author

StefanBerger-DFINITY Merci!

@StefanBerger-DFINITY
Copy link

@DeLemonCH will address that asap. @DenysKarmazynDFINITY that should be in your todo list in the next few minutes

@StefanBerger-DFINITY
Copy link

The diff is 0.00002066, which is about the transaction fees of ~2 USD.
So this is still the MAX problem I assume.
(You could try to send 0.001097544914 instead of the 0.00111783, that should then end up to 0 with the fees..)

@StefanBerger-DFINITY
Copy link

@DeLemonCH sorry to bother again.
The root problem here is of course that the fees must be paid in btc, and they are deducted from the wallet account and not the transfer amount (paid by sender). We currently don't have the fee information at this step, so we can't offer a MAX button there.

But we are working on an improved flow that will show the expected fees, and then we will also provide a MAX button.

@DeLemonCH
Copy link
Author

Hi Stefan, yes I could send it with considering the fee in the full amount - though would have expected it to be taken from the transfer amount.
Thanks anyway!

Merged
DenysKarmazynDFINITY added a commit that referenced this issue Nov 26, 2024
@DenysKarmazynDFINITY
feat(frontend): handle insufficientFundsForFee case in BtcSendReview (#…
bb32a85 
…3755)

# Motivation

This PR fixes issue described
[here](#3480 (comment))
- there was no check in the BTC send flow which makes sure that provided
amount and related utxos fee do not exceed available balance.

The component now checks `insufficientFundsForFee` case, disabled "send"
button if it's true, as well as shows the following user message:

<img width="627" alt="error"
src="https://github.com/user-attachments/assets/6d7aa80c-261b-4ee7-a4db-31dfbd91d9a6">
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@StefanBerger-DFINITY StefanBerger-DFINITY

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@DeLemonCH @DenysKarmazynDFINITY @StefanBerger-DFINITY