-
Notifications
You must be signed in to change notification settings - Fork 69
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Perform some simple preprocessing of contractions #114
Comments
This does need to be optional and I would think a default off state to retain current functionality. I am a bit hesitant to make changes to current algorithms without discussing more with downstream programs. Disjoint subgraphs seems like it would influence each algorithm differently and likely not able to be generalized. Similar to the path combination, each algorithm uses different internal structures at the moment and likely needs to remain that way for performance. |
@jcmgray I might try this today, are you working on any pieces currently? |
I'm adding a few tweaks to the 'dp' algorithm, (with an eye on it replacing the current 'optimal' implementation) but that's all pretty much self contained! |
It might be sensible (#99 and #112) for
opt_einsum
to perform some simple universal pre-processing of contractions before sending them to the actual path optimizers. Including:abc->ab
where the indexc
appears on no other termsab,ab->ab
Some things to think about
The text was updated successfully, but these errors were encountered: