Implement calling UNO #59
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Includes a few improvements over what was just removed from master, like a message explaining that a D2 has occurred and better guarding against a player spamming 'uno' to get more cards.
There's no penalty for lying about having UNO. Reworked how the logic works, but it's not completely tested. However, we now have calling, challenging, penalty cards for a valid call-out if someone is caught forgetting to call UNO... Reasonably done.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm just going to open this. I think it's fairly complete, and the merge conflict isn't big enough to sacrifice the branched history graph with a rebase.
This feature should look cool in gitk/SourceTree/etc. years from now. 😝
Closes #7.