chain-space: Fix bug of Space Creator Delegating Themselves #505
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vatsa287
force-pushed
the
fix-chainspace-bug
branch
2 times, most recently
from
ca2f10a
to
6c4d1f7
Compare
amarts
previously approved these changes
Sep 11, 2024
vatsa287
force-pushed
the
fix-chainspace-bug
branch
from
6c4d1f7
to
c294d72
Compare
amarts
previously approved these changes
Sep 11, 2024
Signed-off-by: Shreevatsa N <[email protected]>
vatsa287
force-pushed
the
fix-chainspace-bug
branch
from
c294d72
to
f7f3709
Compare
amarts
approved these changes
Sep 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a check which disallows
creatorof the space delegating themselves, thereby avoiding two entries ofdelegatesbelonging to the same sourcedid, anywaycreatorwill have7permission bits.This avoids potential case of getting
UnAuthorizedOperationeven though the account posses sufficient permissions.