Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] Add a -H/--hash-function option. #1623

Open
wants to merge 11 commits into
base: master
Choose a base branch
from
Open

[WIP] Add a -H/--hash-function option. #1623

wants to merge 11 commits into from

Conversation

ctb
Copy link
Member

@ctb ctb commented Feb 16, 2017

As per #1613 and #1511 (comment), this adds -H/--hash-function to countgraph creation. Among other things, this:

  • adds a function khmer_args.create_counttable(...) analog of khmer_args.create_countgraph(...).

Some notes:

  • we will need a load_counttable that properly picks up on khmer.Countgraph and khmer.Counttable.
  • Is it mergeable?
  • make test Did it pass the tests?
  • make clean diff-cover If it introduces new functionality in
    scripts/ is it tested?
  • make format diff_pylint_report cppcheck doc pydocstyle Is it well
    formatted?
  • Did it change the command-line interface? Only backwards-compatible
    additions are allowed without a major version increment. Changing file
    formats also requires a major version number increment.
  • For substantial changes or changes to the command-line interface, is it
    documented in CHANGELOG.md? See keepachangelog
    for more details.
  • Was a spellchecker run on the source code and documentation after
    changes were made?
  • Do the changes respect streaming IO? (Are they
    tested for streaming IO?)

@ctb ctb mentioned this pull request Feb 16, 2017
@ctb
Copy link
Member Author

ctb commented Feb 17, 2017

Update: it's pretty clear that this can't make it into 2.1 because we are going to have to change file formats to store what kind of object something is. Good to know :).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant