Document possible problem with the SPARQLProtocolWorker and the conne…

…cted client
dice-group · Nov 6, 2023 · 675e1f5 · 675e1f5
1 parent dfb4666
commit 675e1f5
Showing 1 changed file with 3 additions and 0 deletions.
diff --git a/src/main/java/org/aksw/iguana/cc/worker/impl/SPARQLProtocolWorker.java b/src/main/java/org/aksw/iguana/cc/worker/impl/SPARQLProtocolWorker.java
@@ -348,6 +348,9 @@ private HttpExecutionResult executeHttpRequest(Duration timeout) {
 
         // check if the last execution task is stuck
         if (this.httpClient.executor().isPresent() && ((ThreadPoolExecutor) this.httpClient.executor().get()).getActiveCount() != 0) {
+            // This might never cancel the task if the client that's connected to is broken. There also seems to be a
+            // bug where the httpClient never properly handles the interrupt from the shutdownNow method.
+            // See: https://bugs.openjdk.org/browse/JDK-8294047
             ((ThreadPoolExecutor) this.httpClient.executor().get()).shutdownNow();
             final var waitStart = Instant.now();
             try {