Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Single point of version definition #278

Open
bigerl opened this issue Sep 16, 2024 · 0 comments · Fixed by #285
Open

Single point of version definition #278

bigerl opened this issue Sep 16, 2024 · 0 comments · Fixed by #285
Assignees
@nck-mlcnv
Labels
enhancement help wanted

Comments

@bigerl
Copy link
Member

bigerl commented Sep 16, 2024

At the moment, the iguana version is used in several places across the repo. This should not be the case. Where it is really needed, like in the ontology file, it should be done with a template. I would suggest jinjava
@nck-mlcnv nck-mlcnv self-assigned this Oct 1, 2024
@nck-mlcnv nck-mlcnv linked a pull request Oct 1, 2024 that will close this issue
Single point version definition #285
Merged
nck-mlcnv added a commit that referenced this issue Oct 19, 2024
@nck-mlcnv
Single point version definition (#285)
dd48631 
* Remove iguana version number from script

* Remove old files

* Move ontology file to resource folder and set version as variable

* Update deployment

* Separate ontology version from project version

* Add github action for checking ontology version

* Update file permissions

* Update ontology version

* Add a version command line option

* Fix resources configuration

* Change version information format

* Fix version output

Closes #278
@bigerl bigerl closed this as completed Oct 30, 2024
@bigerl bigerl reopened this Oct 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@nck-mlcnv nck-mlcnv

Labels
enhancement help wanted
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Single point version definition dice-group/IGUANA
2 participants
@bigerl @nck-mlcnv