Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Result aggregation for Pattern Queries #279

Open
aalexandrasilva opened this issue Sep 18, 2024 · 0 comments · May be fixed by #283
Open

Result aggregation for Pattern Queries #279

aalexandrasilva opened this issue Sep 18, 2024 · 0 comments · May be fixed by #283
Assignees
Labels
Milestone

Comments

@aalexandrasilva
Copy link

aalexandrasilva commented Sep 18, 2024

Hello 👋

The original pattern query implementation included a result subsumption of the results of the instance queries.
As mentioned in version 3.3.3 documentation:

For each result (limited to 2000) a query instance will be created.

This will be done for every query in the benchmark queries. All instances of these query patterns will be subsummed as if they were one query in the results.

Currently, iguana computes the metrics separately for each of the query instances.
Would you consider adding this result aggregation back? 😄

@bigerl bigerl linked a pull request Sep 27, 2024 that will close this issue
2 tasks
@nck-mlcnv nck-mlcnv self-assigned this Oct 1, 2024
@bigerl bigerl added this to the 5.0 milestone Oct 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants