Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for React 19 #2935

Closed
JacobWeisenburger opened this issue Nov 14, 2024 · 4 comments
Closed

Add support for React 19 #2935

JacobWeisenburger opened this issue Nov 14, 2024 · 4 comments

Comments

@JacobWeisenburger
Copy link

JacobWeisenburger commented Nov 14, 2024

"peerDependencies": {
"react": "^16.8.0 || ^17.0.0 || ^18.0.0"
},

I tried updating to Next 15 and React 19, but @react-pdf/renderer didn't work properly, so I had to revert back to Next 14 and React 18

C:\Software\royal-dr…onents\Modal.tsx:24 TypeError: Cannot read properties of undefined (reading 'hasOwnProperty')
    at $$$reconciler (react-pdf.browser.js:134:11)
    at createRenderer (react-pdf.browser.js:4030:12)
    at pdf (react-pdf.browser.js:4237:28)
    at eval (react-pdf.browser.js:4485:31)
    at react-stack-bottom-frame (react-dom-client.development.js:22420:20)
    at runWithFiberInDEV (react-dom-client.development.js:544:16)
    at commitHookEffectListMount (react-dom-client.development.js:10732:29)
    at commitHookPassiveMountEffects (react-dom-client.development.js:10852:11)
    at commitPassiveMountOnFiber (react-dom-client.development.js:12627:13)
    at recursivelyTraversePassiveMountEffects (react-dom-client.development.js:12601:11)
    at commitPassiveMountOnFiber (react-dom-client.development.js:12729:11)
    at recursivelyTraversePassiveMountEffects (react-dom-client.development.js:12601:11)
    at commitPassiveMountOnFiber (react-dom-client.development.js:12620:11)
    at recursivelyTraversePassiveMountEffects (react-dom-client.development.js:12601:11)
    at commitPassiveMountOnFiber (react-dom-client.development.js:12620:11)
    at recursivelyTraversePassiveMountEffects (react-dom-client.development.js:12601:11)
    at commitPassiveMountOnFiber (react-dom-client.development.js:12697:17)
    at recursivelyTraversePassiveMountEffects (react-dom-client.development.js:12601:11)
    at commitPassiveMountOnFiber (react-dom-client.development.js:12729:11)
    at recursivelyTraversePassiveMountEffects (react-dom-client.development.js:12601:11)
    at commitPassiveMountOnFiber (react-dom-client.development.js:12729:11)
    at recursivelyTraversePassiveMountEffects (react-dom-client.development.js:12601:11)
    at commitPassiveMountOnFiber (react-dom-client.development.js:12729:11)
    at recursivelyTraversePassiveMountEffects (react-dom-client.development.js:12601:11)
    at commitPassiveMountOnFiber (react-dom-client.development.js:12620:11)
    at recursivelyTraversePassiveMountEffects (react-dom-client.development.js:12601:11)
    at commitPassiveMountOnFiber (react-dom-client.development.js:12620:11)
    at recursivelyTraversePassiveMountEffects (react-dom-client.development.js:12601:11)
    at commitPassiveMountOnFiber (react-dom-client.development.js:12729:11)
    at recursivelyTraversePassiveMountEffects (react-dom-client.development.js:12601:11)
    at commitPassiveMountOnFiber (react-dom-client.development.js:12729:11)
    at recursivelyTraversePassiveMountEffects (react-dom-client.development.js:12601:11)
    at commitPassiveMountOnFiber (react-dom-client.development.js:12620:11)
    at recursivelyTraversePassiveMountEffects (react-dom-client.development.js:12601:11)
    at commitPassiveMountOnFiber (react-dom-client.development.js:12729:11)
    at recursivelyTraversePassiveMountEffects (react-dom-client.development.js:12601:11)
    at commitPassiveMountOnFiber (react-dom-client.development.js:12620:11)
    at recursivelyTraversePassiveMountEffects (react-dom-client.development.js:12601:11)
    at commitPassiveMountOnFiber (react-dom-client.development.js:12620:11)
    at recursivelyTraversePassiveMountEffects (react-dom-client.development.js:12601:11)
    at commitPassiveMountOnFiber (react-dom-client.development.js:12729:11)
    at recursivelyTraversePassiveMountEffects (react-dom-client.development.js:12601:11)
    at commitPassiveMountOnFiber (react-dom-client.development.js:12620:11)
    at recursivelyTraversePassiveMountEffects (react-dom-client.development.js:12601:11)
    at commitPassiveMountOnFiber (react-dom-client.development.js:12729:11)
    at recursivelyTraversePassiveMountEffects (react-dom-client.development.js:12601:11)
    at commitPassiveMountOnFiber (react-dom-client.development.js:12729:11)
    at recursivelyTraversePassiveMountEffects (react-dom-client.development.js:12601:11)
    at commitPassiveMountOnFiber (react-dom-client.development.js:12729:11)
    at recursivelyTraversePassiveMountEffects (react-dom-client.development.js:12601:11)

The above error occurred in the <PDFViewer> component. It was handled by the <ReactDevOverlay> error boundary. Error Component Stack
    at PDFViewer (react-pdf.browser.js:4514:22)
    at dialog (<anonymous>)
    at Dialog (C:\Software\royal-dr…ts\Dialog.tsx:11:29)
    at Modal (C:\Software\royal-dr…nts\Modal.tsx:71:31)
    at Suspense (<anonymous>)
    at body (<anonymous>)
    at html (<anonymous>)
    at RootLayout (C:\Software\royal-dr…pp\layout.tsx:19:35)
    at ClientSegmentRoot (client-segment.js:14:11)
    at RedirectErrorBoundary (redirect-boundary.js:74:9)
    at RedirectBoundary (redirect-boundary.js:82:11)
    at NotFoundErrorBoundary (not-found-boundary.js:76:9)
    at NotFoundBoundary (not-found-boundary.js:84:11)
    at DevRootNotFoundBoundary (dev-root-not-found-boundary.js:33:11)
@diegomura
Copy link
Owner

Duplicated: #2756

Please consider looking for existing issues before creating a new one. It was literally the first one on the issues page

@JacobWeisenburger
Copy link
Author

It was literally the first one on the issues page

image

it's on page 4 of the issues. So you are "literally" incorrect.

https://github.com/diegomura/react-pdf/issues?page=4&q=is%3Aissue+is%3Aopen

@diegomura
Copy link
Owner

diegomura commented Nov 14, 2024

With that filter yes, but GH automatically sort things by updated-desc. So it shows up first at least to me when I click "issues"

That's no excuse though. Page 1 or 4 the least you can do is checking. There's a search bar you can use too

Screenshot 2024-11-14 at 5 13 43 PM

@JacobWeisenburger
Copy link
Author

JacobWeisenburger commented Nov 14, 2024

I tried searching and nothing relavant came up:

image

github search is not always very helpful just so you know

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants