fix(gen): Use yeoman.{styles,app} variable instead of hardcoded strings in Gruntfile template. #158
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
huerlisi
changed the title
|
Also includes a fix to replace |
huerlisi
changed the title
huerlisi
changed the title
| @@ -278,7 +278,7 @@ module.exports = function (grunt) { | |||
| }, | |||
| fonts: { | |||
| expand: true, | |||
| cwd: 'app/lib/ionic/release/fonts/', | |||
| cwd: '<%%= yeoman.app %>/lib/ionic/release/fonts/', | |||
There was a problem hiding this comment.
This should be: cwd: '<%= yeoman.app %>/bower_components/ionic/release/fonts/',
huerlisi
force-pushed
the
fixes/use-yeoman-styles
branch
2 times, most recently
from
4c88386 to
0001b80
Compare
huerlisi
force-pushed
the
fixes/use-yeoman-styles
branch
from
0001b80 to
67eef55
Compare
|
@beaubrewer thanks for the hint regarding Rebase on master and updated the commit messages to follow conventions. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.