Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support inline annotation body deserialisation #56

Open
donaldgray opened this issue Nov 20, 2024 · 0 comments
Open

Support inline annotation body deserialisation #56

donaldgray opened this issue Nov 20, 2024 · 0 comments
Labels
enhancement New feature or request serialization Related to serialization / deserialization

Comments

@donaldgray
Copy link
Member

donaldgray commented Nov 20, 2024

Inline-annotation bodies are being lost on deserialisation. E.g. a manifest with

"items": [{
  "annotations": [{
    "id": "https://example/annopage/p1",
    "type": "AnnotationPage",
    "items": [{
      "id": "https://example/annopage/p1/a1",
      "type": "Annotation",
      "motivation": "describing",
      "body": {
        "type": "TextualBody",
        "value": "something",
        "format": "text/html"
      },
      "target": {
        "id": "https:/example/canvas/c0#xywh=1800,2000,500,500",
        "type": "Canvas"
    }

currently results in the body being completely lost and target is link only (verify - is this okay)?:

"items": [{
  "annotations": [{
    "id": "https://example/annopage/p1",
    "type": "AnnotationPage",
    "items": [{
      "id": "https://example/annopage/p1/a1",
      "type": "Annotation",
      "motivation": "describing",
      "target": "https://example/canvas/c0#xywh=1800,2000,500,500"
  },

Above example is taken from https://stephenwf.github.io/ocean-liners.json

@donaldgray donaldgray added enhancement New feature or request serialization Related to serialization / deserialization labels Nov 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request serialization Related to serialization / deserialization
Projects
None yet
Development

No branches or pull requests

1 participant